Fix types for ARM SIMD32 intrinsics #1679
Open
+43
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amanieu: no appropriate reviewer found, use |
These were previously defined using vector types which is incorrect.
Instead, `{u}int{8x4,16x2}_t` are aliases for `i32` and `u32`.
This also fixes CI since these types don't need to be passed in NEON
registers and this was triggering a newly added compiler warning.
Amanieu
force-pushed
the
fix-simd32-types
branch
from
44f5a55
to
609906f
Compare
|
@heiher LoongArch seems to have been broken by rust-lang/rust#116558 as well, but I think the lint may be triggering incorrectly in that case? Perhaps this needs to be fixed on the compiler side? |
|
Sorry that should be @heiher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously defined using vector types which is incorrect. Instead,
{u}int{8x4,16x2}_tare aliases fori32andu32.This also fixes CI since these types don't need to be passed in NEON registers and this was triggering a newly added compiler warning.