Skip to content

Perform first rustc pull #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 7, 2025
+5 −1
Merged

Perform first rustc pull #1844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c014f0a
Update README.md
kilavvy Jun 29, 2025
97fa048
Rollup merge of #143176 - kilavvy:master, r=jieyouxu
dianqk Jun 30, 2025
2b9fa3b
Rollup merge of #143187 - yotamofek:mailmap, r=jieyouxu
dianqk Jun 30, 2025
53402a0
Rollup merge of #143190 - dianqk:new-method, r=oli-obk
dianqk Jun 30, 2025
7a696e0
Rollup merge of #143195 - Kivooeo:tf17, r=tgross35
dianqk Jun 30, 2025
0388fdb
Rollup merge of #143196 - Periodic1911:link_section, r=oli-obk
dianqk Jun 30, 2025
d64ae73
Rollup merge of #143199 - jieyouxu:short-ice, r=RalfJung
dianqk Jun 30, 2025
791992a
Rollup merge of #143219 - zachs18:patch-5, r=tgross35
dianqk Jun 30, 2025
51f0bad
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
bors Jun 30, 2025
1ab351a
Auto merge of #143239 - GuillaumeGomez:subtree-update_cg_gcc_2025-06-…
bors Jun 30, 2025
318e3dc
Auto merge of #141875 - nnethercote:ByteSymbol, r=petrochenkov
bors Jul 1, 2025
d246a8c
Auto merge of #142921 - JonathanBrouwer:rustc_attributes_parser, r=ol…
bors Jul 1, 2025
54d399e
Auto merge of #142030 - oli-obk:wfck-less-hir, r=compiler-errors
bors Jul 1, 2025
fa7ac71
Auto merge of #143214 - camsteffen:remove-let-chains-feature, r=est31
bors Jul 2, 2025
0545c25
Auto merge of #142910 - yotamofek:pr/rustdoc/markdown-lazy-to-string,…
bors Jul 3, 2025
2c2c768
Auto merge of #142890 - kornelski:unused-var-debug, r=saethlin
bors Jul 3, 2025
a73bceb
Add config files for `rustc-josh-sync`
Kobzol Jul 4, 2025
6fc1814
Prepare for merging from rust-lang/rust
Kobzol Jul 4, 2025
4571e48
Merge ref '1b61d43bdbf8' from rust-lang/rust
Kobzol Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/intrinsic-test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ USAGE:
intrinsic-test [FLAGS] [OPTIONS] <INPUT>
FLAGS:
--a32 Run tests for A32 instrinsics instead of A64
--a32 Run tests for A32 intrinsics instead of A64
--generate-only Regenerate test programs, but don't build or run them
-h, --help Prints help information
-V, --version Prints version information
Expand Down
3 changes: 3 additions & 0 deletions josh-sync.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
org = "rust-lang"
repo = "stdarch"
path = "library/stdarch"
1 change: 1 addition & 0 deletions rust-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1b61d43bdbf875183b1f436302d62ff93f9a6bba
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally CI would use this to determine the Rust version to test, that'd made it stable under rustc repo changes... but that's a future TODO I think :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting idea. It would mean that if there is a breaking change in rustc, we would only recognize it during the next pull (instead of recognizing it the next day when nightly is bumped). So we should combine this technique with having CI that will do an automatic pull every night to give us faster feedback when r-l/r changes break something in stdarch. I assume that's what miri does, right?

Copy link
Member

@RalfJung RalfJung Jul 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically we have a nightly CI job that starts with:

git ls-remote https://github.com/rust-lang/rust/ HEAD | cut -f 1 > rust-version

So we test against the latest rustc every night, and we get a Zulip message if that job fails. But even if rustc breaks, that doesn't affect unrelated PRs. If CI fails in a PR, that's always the fault of the PR because everything is pinned. IMO that is a quite important property to have.

This is orthogonal to the automatic pull, though we do both in the same CI cronjob.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is nice, yeah. I'll take a look at it once we have rustc-josh-sync for stdarch up & running.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to explain any questions about our CI setup that might come up. :) We spent quite a bit of effort on it over the years and I think it has served us well.