intrinsic-test: Coalescing all intrinsic tests into a single run of the test-file binaries
#1952
Conversation
instead of len(intrinsic) output streams
|
@folkertdev I was able to run 30% of the intrinsics and get a 17-minute CI runtime. |
folkertdev
left a comment
folkertdev
left a comment
There was a problem hiding this comment.
Very encouraging results!
ci/intrinsic-test.sh
Outdated
| TEST_RUNNER="${CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER}" | ||
| TEST_SKIP_INTRINSICS=crates/intrinsic-test/missing_x86.txt | ||
| : "${TEST_SAMPLE_INTRINSICS_PERCENTAGE:=5}" | ||
| : "${TEST_SAMPLE_INTRINSICS_PERCENTAGE:=30}" |
There was a problem hiding this comment.
please adjust this so that it is not the longest CI job. I think the next-longest job is 11 minutes now.
There was a problem hiding this comment.
Sure, let me dial it down to 20%.
| .to_lowercase() | ||
| .replace("-nan", "nan"); | ||
| let c_output_map = c | ||
| .split("############") |
There was a problem hiding this comment.
can you put this marker into a const and use that instead of repeating the literal characters?
| ); | ||
| let (c, rust) = match (c, rust) { | ||
| (Ok(c), Ok(rust)) => (c, rust), | ||
| a => panic!("{a:#?}"), |
There was a problem hiding this comment.
let's call this "failure" or something a bit more descriptive
madhav-madhusoodanan
force-pushed
the
intrinsic-test-updates
branch
from
b29cd98 to
c94fd76
Compare
|
The longest process is the C++/Rust binary runs (which run on a single thread each, in parallel) I think the next optimization would be parallelizing the binary runs themselves. |
2 participants
No description provided.