Skip to content

Conversation

alexcrichton
Copy link
Member

Support isn't quite in nightly to make this work yet, but using a local build
this gets everything passing again! This also implements native verification
that we have the attribute in the right place

@alexcrichton alexcrichton requested a review from gnzlbg February 10, 2018 16:59
@alexcrichton
Copy link
Member Author

FWIW this is blocked on rust-lang/rust#48078 reaching nightlies

#[inline]
#[target_feature(enable = "avx")]
#[cfg_attr(test, assert_instr(vshufpd, imm8 = 0x1))]
#[rustc_args_required_const(2)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like supporting attributes attached directly to function parameters would help with cases like this.
*Adds it to the list of things to implement some time*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!

@alexcrichton alexcrichton force-pushed the const branch 3 times, most recently from e78e13a to a46b0d2 Compare February 11, 2018 16:08
Support isn't quite in nightly to make this work yet, but using a local build
this gets everything passing again! This also implements native verification
that we have the attribute in the right place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants