Fix build when used as a submodule #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnzlbg
approved these changes
Nov 19, 2018
|
Please don't merge yet, I just found another issue |
|
Ping me when I should merge. I'm going to try to add a test for updating the submodule to stdsimd's CI. |
jethrogb
force-pushed
the
jb/fix-submodule-build
branch
from
ab66abf to
2224d64
Compare
|
Take 2 |
Merged
jethrogb
force-pushed
the
jb/fix-submodule-build
branch
from
2224d64 to
727adf9
Compare
|
Build failures: ARM & Windows is not this PR's fault, I think. I fixed rustfmt. |
|
That windows job is broken on master as well, so don't worry about it, I'll take a look later. |
jethrogb
force-pushed
the
jb/fix-submodule-build
branch
from
727adf9 to
37d0935
Compare
|
Ok one more time |
|
Thanks! Let me know if upgrading it upstream succeeds! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this with a local checkout of https://github.com/rust-lang/rust/
Ideally CI would update the submodule and run
cargo +nightly checkinsidesrc/libstd.