Revert #558. Fixes #603. #604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i586/i686 tests also fail on master: https://travis-ci.org/rust-lang-nursery/stdsimd/builds/460124295 |
|
We should fix this, not revert it. The question is: why does this break on rust-lang/rust but works fine here ? |
|
IIRC the problem was that the |
|
Agreed yeah, would it be possible to get a gist of the error logs to see if we can fix it without reverting? |
|
See #603 |
|
That's fixed in #609 |
|
So I'm closing this, since it should be now fixed on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "do not validate the argument to the __breakpoint intrinsic", "aarch64 support and range validation", "fix typo", "fix assert_instr test", "remove TODO; add link to doc comment", "add __breakpoint"
This reverts commits 7fbd636, 72b4143, 9e5c960, 8b84dc4, af7c166, 40f61c7.