Use primitive type associated constants #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Apr 4, 2020
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 7, 2020
…tolnay Use assoc int submodules Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them: * rust-lang/nomicon#207 * rust-lang/rust-by-example#1327 * rust-lang/stdarch#848 But for some, a few more changes slipped by that happened to be in the master branch of these submodules. r? @dtolnay
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 7, 2020
…tolnay Use assoc int submodules Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them: * rust-lang/nomicon#207 * rust-lang/rust-by-example#1327 * rust-lang/stdarch#848 But for some, a few more changes slipped by that happened to be in the master branch of these submodules. r? @dtolnay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the primitive type associated constants throughout stdarch
std::<int/float type>since those constants are now available on the primitive types directly.min_value()withMINandmax_value()withMAX.std::from allstd::<int/float type>::MIN/MAXusage.If reviewing seems too daunting or the usage of
min_valueandmax_valuedoes not seem that bad, I can remove that specific commit since it's most of the lines. The other two commits should at least stop using the std modules, which is a good step in the right direction and would entail far fewer changes.r? @dtolnay