Add a principles and guidelines section #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes discussion of trailing commas which closes #42
perlun
reviewed
Dec 8, 2017
| @@ -0,0 +1,51 @@ | |||
| # Guiding principles and rationale | |||
|
|
|||
| When deciding on style guidelines, the style team tried to be guided by the | |||
There was a problem hiding this comment.
"tried" or "tries" @nrc? This seems like a typo.
There was a problem hiding this comment.
Sorry, I missed this comment earlier. I think this is correct, the guide is meant to be an archival document so when it is committed the style RFC process will be in the past and so the past tense will be correct here.
There was a problem hiding this comment.
OK, thanks! That's fine, just wanted to verify. Thanks for clarifying.
|
@nrc - see my comment above. There seems to be a typo in the text you merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes discussion of trailing commas which closes #42