-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customisation #33
Customisation #33
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
- Start Date: 2016-10-25 | ||
- RFC Issue: #3 | ||
- RFC PR: | ||
- Implementation Issue: (leave this empty) | ||
|
||
# Summary | ||
[summary]: #summary | ||
|
||
Customisation of Rustfmt should be allowed (via a `rustfmt.toml` file), but | ||
discouraged. | ||
|
||
|
||
# Details | ||
[details]: #details | ||
|
||
A formatter such as Rustfmt may be customised by the user. These customisations | ||
may be saved for a project using a customisation file. For example, Rustfmt can | ||
be customised by either a `rustfmt.toml` or `.rustfmt.toml` in their project | ||
directory or any parent of that directory. Rustfmt will read options from the | ||
first toml file (scanning up the directory tree). If an option is not present in | ||
the file, Rustfmt uses the default option (as specified by the code style | ||
process RFCs). The set of options available is not specified at this time; it | ||
will be part of the style RFC process to enumerate them. | ||
|
||
A formatting tool may be customised in other ways, but must stick to the options | ||
and defaults specified by the style RFCs. | ||
|
||
Customisation will be documented, but explicitly discouraged. | ||
|
||
All official Rust projects which use Rustfmt *must* use the default style and | ||
*must not* include a customisation file. | ||
|
||
# Implementation | ||
[implementation]: #implementation | ||
|
||
Rustfmt already allows customisation via `rustfmt.toml`. There is nothing more | ||
to implement here. During the style RFC process, I expect the number of options | ||
to be reduced. | ||
|
||
See [config.rs](https://github.com/rust-lang-nursery/rustfmt/blob/master/src/config.rs) | ||
for the definition of the config file. | ||
|
||
# Rationale | ||
[rationale]: #rationale | ||
|
||
Beyond the advantage of automatically formatting code, there is a large | ||
advantage in all code being formatted the same way. This holds within a single | ||
project, and between projects - reading code in a new project is easier if one | ||
does not have to adjust to a new code style at the same time. Since Rust | ||
encourages sharing small crates between projects, this is likely to be a bigger | ||
advantage in Rust than, say, C++. | ||
|
||
However, code style is an intensely subjective matter and many programmers feel | ||
strongly about it. It is therefore likely that if Rustfmt only enforced a | ||
single style, the tool would be rejected by a significant proportion of the | ||
community. | ||
|
||
The advantages of a single style are only realised if a critical mass of the | ||
community follow that style. We believe that we will not reach that critical | ||
mass. Therefore, it is better to allow customisation so that more projects will | ||
use rustfmt (in any configuration). | ||
|
||
We also believe that the best approach to encouraging use of the default style | ||
is to lead by example and exert cultural pressure, rather than enforcement by | ||
coercion. | ||
|
||
# Alternatives | ||
[alternatives]: #alternatives | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A bit of bikeshedding: Any consideration for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. both work, as described in the details section There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Woops, missed that. I think I need to sleep 💤 |
||
|
||
No customisation is an alternative. However, we believe this will reduce | ||
Rustfmt's usage and users will either fork Rustfmt or move to a more flexible | ||
formatting tool. | ||
|
||
A number of possible 'speed bumps' have been proposed (most are described in | ||
https://github.com/rust-lang-nursery/fmt-rfcs/issues/3). These aim to add a | ||
technical barrier to customisation as well as a social/cultural one. We decided | ||
that any of these measures would be annoying without being effective, and instead | ||
we should rely on cultural pressure. | ||
|
||
# Unresolved questions | ||
[unresolved]: #unresolved-questions | ||
|
||
How should we control the options Rustfmt makes available? I feel that the | ||
current set of options is too large (catering for some very niche formatting, | ||
and imposing a cost in complexity and hugely expanded scope for bugs), and is | ||
not very coherent. We have considered having RFCs include a set of alternatives | ||
that Rustfmt will support, however, it has been suggested that this might make | ||
the alternatives too official and is perhaps beyond the scope of the style RFC | ||
process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we go from "not encouraged" to "explicitly discouraged", a somewhat stronger form of "non-encouragement".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think explicit discouragement is what we want. I'll try and make sure this is consistent throughout.