-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: reorg to frontend subteam for UI/UX and main team #1474
rustdoc: reorg to frontend subteam for UI/UX and main team #1474
Conversation
Thanks! Let's ping the whole team to see if others want to be part of it as well. cc @rust-lang/rustdoc |
I think the PR's title was meant to reference the team rustdoc-contributors not rustdoc? |
teams/rustdoc-frontend.toml
Outdated
name = "Rustdoc team contributors" | ||
description = "Contributing to Rustdoc on a regular basis" | ||
name = "Rustdoc web frontend" | ||
description = "Rustdoc frontend design and development" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention the terms UI, UX and/or HTML somewhere here? Or just change "frontend" to "web frontend" to disambiguate it?
/me having a giggle about the fact that rustdoc's (web) frontend is actually one of rustdoc's backends from a compiler perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wait till rustdoc has a seperate team responsible for cleaning from HIR and metadata :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, please!
Sure, I'll name drop UX, UI in the description. Should I change the title to "rustdoc-contributors: reorg to frontend subteam"? I know that git thinks I'm renaming it, because the files are so similar, but this new subteam doesn't actually have much overlap with the one being removed. The set of people in the team is completely different. Both teams are intended to reduce review workload for some contributors, but they're addressing it in entirely opposite ways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also like to be part of the new team.
Ah, no it's fine as is 👍. I think I misread the title |
Is this good to merge? r? @GuillaumeGomez |
Not yet, waiting for https://github.com/rust-lang/team/pull/1474/files#r1637422119 to be updated then it's good to go. |
Thanks @notriddle ! @jackh726 It's now ready for merge. |
https://rust-lang.zulipchat.com/#narrow/stream/393423-t-rustdoc.2Fmeetings/topic/meeting.202024-06-10/near/438892399