Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: reorg to frontend subteam for UI/UX and main team #1474

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

notriddle
Copy link
Contributor

@notriddle
Copy link
Contributor Author

CC @GuillaumeGomez @jsha

@GuillaumeGomez
Copy link
Member

Thanks! Let's ping the whole team to see if others want to be part of it as well.

cc @rust-lang/rustdoc

@fmease
Copy link
Member

fmease commented Jun 11, 2024

I think the PR's title was meant to reference the team rustdoc-contributors not rustdoc?

name = "Rustdoc team contributors"
description = "Contributing to Rustdoc on a regular basis"
name = "Rustdoc web frontend"
description = "Rustdoc frontend design and development"
Copy link
Member

@fmease fmease Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the terms UI, UX and/or HTML somewhere here? Or just change "frontend" to "web frontend" to disambiguate it?

/me having a giggle about the fact that rustdoc's (web) frontend is actually one of rustdoc's backends from a compiler perspective.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wait till rustdoc has a seperate team responsible for cleaning from HIR and metadata :P

Copy link
Member

@aDotInTheVoid aDotInTheVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please!

@notriddle
Copy link
Contributor Author

notriddle commented Jun 11, 2024

Sure, I'll name drop UX, UI in the description.

Should I change the title to "rustdoc-contributors: reorg to frontend subteam"? I know that git thinks I'm renaming it, because the files are so similar, but this new subteam doesn't actually have much overlap with the one being removed.

The set of people in the team is completely different. Both teams are intended to reduce review workload for some contributors, but they're addressing it in entirely opposite ways.

Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also like to be part of the new team.

@fmease
Copy link
Member

fmease commented Jun 20, 2024

Should I change the title to "rustdoc-contributors: reorg to frontend subteam"?

Ah, no it's fine as is 👍. I think I misread the title

@jackh726
Copy link
Member

Is this good to merge? r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Not yet, waiting for https://github.com/rust-lang/team/pull/1474/files#r1637422119 to be updated then it's good to go.

@GuillaumeGomez
Copy link
Member

Thanks @notriddle !

@jackh726 It's now ready for merge.

@jackh726 jackh726 merged commit 17d7460 into rust-lang:master Jun 25, 2024
1 check passed
@notriddle notriddle deleted the notriddle/rustdoc-frontend branch June 25, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants