-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create relnotes-interest-group
ping group
#1613
Conversation
751dff4
to
7f58211
Compare
I'll note that @ehuss suggested to me an interesting alternative approach to this, which is to configure (Supporting the latter would require some work on triagebot.) |
I think that's another valid approach. I will note that using the triagebot notifications on file changes might not be ideal here because that would trigger even on PRs that just do typo fixes (based on existing file-based notifs on r-l/r usages). Whereas a separate notification group is much more deliberate for both T-release as well as people interested in being pinged for the main relnotes PRs (not for typo fixes) I would think. |
This ping group is intended for contributors who would like to get pinged on release notes PRs (PR modifying `RELEASES.md` and the release blog post), intended to help double-check release notes.
7f58211
to
9eb7eb1
Compare
This looks ready, @Mark-Simulacrum |
…r=cuviper triagebot: register `relnotes-interest-group` ping group Part of rust-lang#133334. rust-lang/team#1613 merged. cc T-release discussions in https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang r? release
…r=cuviper triagebot: register `relnotes-interest-group` ping group Part of rust-lang#133334. rust-lang/team#1613 merged. cc T-release discussions in https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang r? release
Rollup merge of rust-lang#135032 - jieyouxu:relnotes-interest-group, r=cuviper triagebot: register `relnotes-interest-group` ping group Part of rust-lang#133334. rust-lang/team#1613 merged. cc T-release discussions in https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang r? release
Tracking issue: rust-lang/rust#133334
This ping group is intended for contributors who would like to get pinged on release notes PRs (PR modifying
RELEASES.md
and the release blog post), intended to help double-check release notes. As @BoxyUwU said:For more context, see https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang.
I don't know if this needs sign-off from anyone... Maybe T-release lead... so I guess
r? @Mark-Simulacrum