Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create relnotes-interest-group ping group #1613

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jieyouxu
Copy link
Member

Tracking issue: rust-lang/rust#133334

This ping group is intended for contributors who would like to get pinged on release notes PRs (PR modifying RELEASES.md and the release blog post), intended to help double-check release notes. As @BoxyUwU said:

If we're going to do this I'd probably prefer having new ping group or something rather than pinging lang directly. This isn't really lang teams area so it's mostly just a "here are some people interested in knowing the release is happening" ping at which point why not do something that other people can use if they want to take an early look at the release posts

For more context, see https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang.

I don't know if this needs sign-off from anyone... Maybe T-release lead... so I guess

r? @Mark-Simulacrum

@jieyouxu jieyouxu force-pushed the relnotes-ping-group branch from 751dff4 to 7f58211 Compare November 23, 2024 01:19
@traviscross
Copy link
Contributor

traviscross commented Dec 7, 2024

I'll note that @ehuss suggested to me an interesting alternative approach to this, which is to configure triagebot to emit pings when the RELEASES.md file changes and when a -Rust-1\.\d+\.\d+\.md blog post is created.

(Supporting the latter would require some work on triagebot.)

@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 8, 2024

I'll note that @ehuss suggested to me an interesting alternative approach to this, which is to configure triagebot to emit pings when the RELEASES.md file changes and when a -Rust-1\.\d+\.\d+\.md blog post is created.

I think that's another valid approach. I will note that using the triagebot notifications on file changes might not be ideal here because that would trigger even on PRs that just do typo fixes (based on existing file-based notifs on r-l/r usages). Whereas a separate notification group is much more deliberate for both T-release as well as people interested in being pinged for the main relnotes PRs (not for typo fixes) I would think.

This ping group is intended for contributors who would like to get
pinged on release notes PRs (PR modifying `RELEASES.md` and the release
blog post), intended to help double-check release notes.
@jieyouxu jieyouxu force-pushed the relnotes-ping-group branch from 7f58211 to 9eb7eb1 Compare December 8, 2024 04:22
@Noratrieb
Copy link
Member

This looks ready, @Mark-Simulacrum

@jackh726 jackh726 merged commit ff982ab into rust-lang:master Jan 2, 2025
1 check passed
@jieyouxu jieyouxu deleted the relnotes-ping-group branch January 2, 2025 15:31
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2025
…r=cuviper

triagebot: register `relnotes-interest-group` ping group

Part of rust-lang#133334.
rust-lang/team#1613 merged.
cc T-release discussions in https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang

r? release
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 8, 2025
…r=cuviper

triagebot: register `relnotes-interest-group` ping group

Part of rust-lang#133334.
rust-lang/team#1613 merged.
cc T-release discussions in https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang

r? release
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
Rollup merge of rust-lang#135032 - jieyouxu:relnotes-interest-group, r=cuviper

triagebot: register `relnotes-interest-group` ping group

Part of rust-lang#133334.
rust-lang/team#1613 merged.
cc T-release discussions in https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang

r? release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants