Add Caleb as co-lead of rustfmt #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caleb will also need to have an email address registered, bsaed on the CI failures. |
killercup
previously approved these changes
Mar 16, 2021
Xanewok
previously approved these changes
Mar 16, 2021
Yup, Manish mentioned this a while back but I never got around to it. Opened #552 |
|
cc @Mark-Simulacrum can you rubber stamp? |
|
It looks like you'll need to rebase or otherwise get the commit bumped for CI to pass here (I guess it runs on the push so open/close didn't help). Otherwise this looks good to me. |
Manishearth
force-pushed
the
Manishearth-patch-2
branch
from
cfda916
to
06da224
Compare
|
Done |
Mark-Simulacrum
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @calebcartwright @topecongiro
We've been unable to reach @topecongiro for a while, and it would be nice if Caleb had all the perms so that he can make progress on rust-lang/rust#82385 . He's been doing a lot of the rustfmt work for quite a while now.
@topecongiro, let me know when you get back and we can discuss this.
r? @rust-lang/devtools