Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opsem team #926

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Add opsem team #926

merged 2 commits into from
Feb 6, 2023

Conversation

JakobDegen
Copy link
Contributor

This PR creates the opsem team, as specified in rust-lang/rfcs#3346 . Welcome everyone, I'm exciting to be getting this team off the ground!

The PR also archives @rust-lang/wg-unsafe-code-guidelines - that work is of course not forgotten, but instead being inherited by the new team. Thanks to everyone who has contributed!

cc @CAD97 , @digama0 , @saethlin , @RalfJung as members and @nikomatsakis and @joshtriplett as lang leads

@JakobDegen
Copy link
Contributor Author

CI is still failing, as Mario does not have an email in the the teams repo - @digama0 , could I ask you to submit a separate PR adding one? I believe github will give you a dummy/anonymous one if you prefer.

Besides that, the PR also refers to a couple things that don't exist yet, and there are a couple other specific infra items that we could use support on. I'm happy to repost these requests elsewhere or implement them myself via follow ups to this repo to the extent that I can (I just don't know enough about what needs to be done here). Specifically:

  • The rust-lang/opsem-team repo does not exist yet. Not sure if it'll be auto-created
  • I also expect that we'll want to keep the rust-lang/unsafe-code-guidelines repo around. Can the permissions on that be set up so that T-opsem has triage and merge perms?
  • For the T-opsem stream on Zulip, I think we should probably rename t-lang/unsafe-code-guidelines . Happy to create a new one if there are objections though.
  • Neither of the Zulip groups exist yet.

@digama0 digama0 mentioned this pull request Jan 26, 2023
@rylev
Copy link
Member

rylev commented Jan 27, 2023

The rust-lang/opsem-team repo does not exist yet.

We do not auto create repos for teams. You can add repos through this repository by following these instructions. You can see how this is done for other repos here.

I also expect that we'll want to keep the rust-lang/unsafe-code-guidelines repo around. Can the permissions on that be set up so that T-opsem has triage and merge perms?

If you can, I would prefer that we create a repo config file (just like the one described above) for the unsafe-code-guidelines repo. This will move configuration away from manual manipulation on GitHub (which is how we used to do things) to the new more transparent way of configuring through the team repo.

For the T-opsem stream on Zulip, I think we should probably rename t-lang/unsafe-code-guidelines . Happy to create a new one if there are objections though.

I can do this once this PR is merged. (unfortunately Zulip streams are still manually managed by admins)

Neither of the Zulip groups exist yet.

These will be automatically created once this PR is merged.

Happy to help with any of this! Thanks so much!

@RalfJung
Copy link
Member

RalfJung commented Jan 27, 2023 via email

@rylev
Copy link
Member

rylev commented Jan 27, 2023

IMO we should rename the repo, not create a new one.

Just a note if you decide to go down this route: this will require someone from infra to do this (I'd be happy to). Once it's done, we can then add the repo's config to the team repo.

@JakobDegen
Copy link
Contributor Author

I am not sure archiving the ucg repo is the right call

I agree (this PR archives the wg, not the repo). I think we should keep using the repo for what it is currently used for. I still think it makes sense to have a separate opsem-team repo though, to use for all the procedural items that team repos typically get used for

@RalfJung
Copy link
Member

this PR archives the wg, not the repo

Oh, I misunderstood then.

In that case, fine for me. Figuring out what to do with the repo (e.g. rename it to attach it more directly to the team) should probably be somewhere early on the team's agenda.

@JakobDegen
Copy link
Contributor Author

@rylev what more is needed to get this PR merged?

@rylev rylev merged commit 718bbc6 into rust-lang:master Feb 6, 2023
@RalfJung
Copy link
Member

RalfJung commented Feb 12, 2023

Shouldn't merging this PR have created @rust-lang/opsem ? No such team seems to exist yet.

@rylev
Copy link
Member

rylev commented Feb 13, 2023

There's a bug in sync-team that has been fixed and is waiting for a review: rust-lang/sync-team#34

@dtolnay dtolnay mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants