Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WG-prioritization member list #992

Merged
merged 1 commit into from
May 31, 2023

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented May 2, 2023

Removing inactive members and moving to alumni section past members.

cc: @wesleywiser

r? @Mark-Simulacrum

@apiraino
Copy link
Contributor Author

apiraino commented May 2, 2023

From the Ci fail:

[ERROR rust_team::validate] validation error: 'TaKO8Ki' was specifically excluded from the Zulip group 'WG-prioritization/alerts' but they were already not included

I honestly don't understand what this sentence is trying to tell me :)

@wesleywiser
Copy link
Member

I think it might be saying that the list here needs to be updated as well:

wesleywiser
wesleywiser previously approved these changes May 2, 2023
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the excluded-people list updated

wesleywiser
wesleywiser previously approved these changes May 2, 2023
@rylev
Copy link
Member

rylev commented May 10, 2023

@apiraino it looks like CI is failing because some folks were removed from the team without being moved to alumni. Validation requires that if someone is in the team repo that they must be there for a reason (even if the reason is to be mentioned in an alumni section). To fix this, we'll need to either add those folks to the alumni section or remove them entirely from the repo. I'll leave it to you to decide which is more appropriate.

@apiraino
Copy link
Contributor Author

thanks @rylev for the suggestion. to be quite honest I don't feel comfortable with the second option, but I'll investigate if it makes sense.

@pnkfelix
Copy link
Member

@apiraino why not move them to alumni then?

@apiraino
Copy link
Contributor Author

ok, I've put them all into the alumni list, though this does not completely reflect reality.

@rylev can you merge when you have one sec? thanks

wesleywiser
wesleywiser previously approved these changes May 26, 2023
@Mark-Simulacrum Mark-Simulacrum merged commit 462f76e into rust-lang:master May 31, 2023
@apiraino apiraino deleted the update-wg-prio branch May 31, 2023 16:24
@dtolnay dtolnay mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants