Skip to content

Not considering unnormalized candidates in method selection for params #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
compiler-errors opened this issue May 21, 2025 · 0 comments · Fixed by rust-lang/rust#141333
Labels
from-crater A regression found via a crater run, not part of our test suite

Comments

@compiler-errors
Copy link
Member

https://crater-reports.s3.amazonaws.com/pr-133502-13/try%233cddd79d4be3c8f1e937d09ca618d192abc69373/gh/cpecu.di-server/log.txt

fn execute<K, F, R>(q: F::Item) -> R
where
    F: Iterator<Item = R>,
    F::Item: Into<K>,
    R: Into<String>,
{
    q.into()
}

Right now F::Item: Into<K> + R: Into<String> doesn't stall F::Item: Into<?0>, which is later inferred to ?0 = R and uses the reflexive impl.

@compiler-errors compiler-errors changed the title Param-env incompleteness is too incomplete? Not considering unnormalized candidates in method selection for params May 21, 2025
@lcnr lcnr added the from-crater A regression found via a crater run, not part of our test suite label May 21, 2025
@lcnr lcnr moved this from unknown to in progress in -Znext-solver=globally May 21, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 21, 2025
Rollup merge of rust-lang#141333 - compiler-errors:param-env-candidate-unnorm, r=lcnr

Use `DeepRejectCtxt` in `assemble_inherent_candidates_from_param`

Fixes rust-lang/trait-system-refactor-initiative#214

We were not properly considering unnormalized param-env candidates in `assemble_inherent_candidates_from_param`.

r? lcnr
@lcnr lcnr moved this from in progress to done in -Znext-solver=globally May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from-crater A regression found via a crater run, not part of our test suite
Projects
Development

Successfully merging a pull request may close this issue.

2 participants