implement the shortcut handler

[Llandy3d]

#1339

This implements the shorcut handler and already works with two shorcuts:

• ready -> S-waiting-on-review
• author -> S-waiting-on-author

It correctly remove the unnecessary label while keeping previous ones. This functionality is accompanied by unit tests.

I do wonder if the author command should be allowed to only team members or it's ok as it is allowed now.

A follow up to this that require more analysis, would be to ping assigned reviewers.

[Llandy3d]

Now it will also ping the appropriate people by leaving a comment:

• ready -> Assignees
• author -> User that opened the pull request

[nikomatsakis]

I'm wondering if we can remove some of this duplicated code. Maybe something like

let shortcuts = [
    ("ready", ShortcutCommand::Ready),
    ("author", ShortcutCommand::Author),
];

for (word, command) in shortcuts {
    if let Some(Token::Word(word)) = toks.peek_token()? { ... }
}

Ok(None)

[Llandy3d]

By using an Hashmap we can avoid looping at all, while having clear the available options

[nikomatsakis]

@Llandy3d ok, I'm ready to merge, but it needs a rebase

[Llandy3d]

@nikomatsakis rebased & resolved conflicts

[nikomatsakis]

Question @Llandy3d -- do we actually check the config at any point? In other words, shortcuts are just always enabled, right? Are the "label editing" commands always enabled? Maybe that checking already happens in set_labels?

[Llandy3d]

Question @Llandy3d -- do we actually check the config at any point? In other words, shortcuts are just always enabled, right? Are the "label editing" commands always enabled? Maybe that checking already happens in set_labels?

Features are not always enabled by default, the check happens in handlers.rs, it seems to happen in the command_handlers macro.

To maintain the current behaviour it's mandatory to configure the shortcuts, if you don't and try to use them you will be greeted by the standard error message:

So the [shortcut] config in triagebot.toml is required

[nikomatsakis]

Got it! Going to merge now, then @Llandy3d can you update the wiki?

[Llandy3d]

@nikomatsakis sure for the wiki, somehow when running tests from the root of the repo it wasn't running parser's tests, fixed a case where it would return a ParseError instead of Ok(None)

[Llandy3d]

The corresponding wiki page can be found here