Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/remove labels instead of setting a new set of labels #1540

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Dec 13, 2021

Setting the full set of labels means that we may race with additions or removals
by the user, which is not the desired behavior. For example, when
autolabeling triggered by files present in a new PR, adding labels would (at
least sometimes) kill labels added by the user, as those are added "after" the
open event is sent, even if immediately specified by the user.

Fixes #1537, #1535

Setting the full set of labels means that we may race with additions or removals
by the user, which is not the desired behavior. For example, when
autolabeling triggered by files present in a new PR, adding labels would (at
least sometimes) kill labels added by the user, as those are added "after" the
open event is sent, even if immediately specified by the user.
This fails when the commit has been rebased, since we'd include the changes from
the previous base to the new base as well.
@Mark-Simulacrum Mark-Simulacrum merged commit a420065 into rust-lang:master Dec 14, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the label-changes branch December 14, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trigger_files removes labels added by user as part of PR creation
1 participant