Add an issue transfer command #1780
Conversation
There was a problem hiding this comment.
Code-wise this looks good.
Permissions-wise, I wonder if it would be to keep this pretty locked-down for now (though I do think once we've tested this a bit we can open up to perms to all team members). If it's possible for us to restrict this to users with write access to both repositories, maybe that would be good. Or, maybe it's not that big of a deal :)
|
The purpose of this PR is to explicitly allow people who don't have write permissions in both repos to use it. If they already have write permissions, they can use the UI to transfer. |
|
Right - my thought is that to start it might be useful for only those people to use this for now (so they can fix things if something goes wrong). But maybe I'm just being to cautious :) |
|
I can merge this with a rebase |
This adds a method to add a generic "errors" handler, so callers don't need to worry about errors if they don't need specific ones. This also drops the generic type, since it wasn't really used.
Thanks, done! |
…r=jackh726 Meta: Enable the brand new triagebot transfer command cc rust-lang/triagebot#1780, rust-lang/rust-forge#741, https://github.com/rust-lang/rust/issues/124619#issuecomment-2094258528 cc `@ehuss,` `@jackh726`
…jackh726 Meta: Enable the brand new triagebot transfer command cc rust-lang/triagebot#1780, rust-lang/rust-forge#741, https://github.com/rust-lang/rust/issues/124619#issuecomment-2094258528 cc `@ehuss,` `@jackh726`
This adds a command to transfer an issue from one repository to another. People occasionally file issues in the wrong repo, and it is convenient to transfer them. Unfortunately you need write access to both repositories to transfer. Often that isn't the case (like transferring between cargo and clippy or vice-versa).
The command is
@rustbot transfer reponame. The source repository needs a[transfer]table to enable the feature.It is restricted to any team member. I'm not sure if that's the right balance of permissions, but I think it is a good starting place, since this is a fairly destructive command.
Unfortunately due to the way the API works, there is no visual indication that the issue has transferred (unlike the Web UI button, which shows a big notice). I think we'll just need to emphasize in the documentation that after the running the command you need to manually reload the page to view it in the new location.
Closes #166