Always allow direct review requests #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should do this in this PR, otherwise people will assign reviewer and not realize that they won't receive any response for a while (or at all). |
Allows `r? <user>` even if they are on a vacation or have full review capacity
Kobzol
force-pushed
the
always-allow-direct-review-request
branch
from
0c1f05a to
3775fcd
Compare
|
Fair enough! Implemented this in the last commit. |
Urgau
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the assignment logic so that it is always possible to
r?users, even if they are on a vacation or if they are at their capacity. When a maximum review capacity or vacation is ignored due to using a direct review request, triagebot will post a warning, telling the requested that the reviewer might take a while to respond.In the future, we can make this behavior configurable.
Requested in https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Review.20queue.20tracking.20in.20triagebot/with/520106062.
Supersedes #1920 (CC @Noratrieb)