Turn automatic backport nominations into suggestions #2191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiraino
force-pushed
the
change-backport-nominations
branch
from
f4c2231 to
c347fd8
Compare
apiraino
commented
Oct 6, 2025
Comment on lines
+220
to
+223
| // Issue/PR authors/reviewers will receive a mention if the template has `{recipients}`. | ||
| let recipients = &mut event.issue.assignees.clone(); | ||
| recipients.push(event.issue.user.clone()); | ||
|
|
There was a problem hiding this comment.
This is different from before: if the template has a {recipients} placeholder, author and reviewers of the PR/issue will receive a mention.
(this change is very specific to my use-case but I think it can be used in other contexts)
apiraino
commented
Oct 6, 2025
| Ok(()) | ||
| } | ||
|
|
||
| async fn get_zulip_ids(ctx: &Context, recipients: &[User]) -> String { |
There was a problem hiding this comment.
this code here is duplicating what we have in src/zulip.rs so a better way would be to refactor that module and expose functions. Maybe another time.
There was a problem hiding this comment.
to generate the mention it's using the trick to write @|12345 where 12345 is the Zulip ID of the user.
|
Let me know if you want a review. |
Kobzol
reviewed
Oct 7, 2025
apiraino
force-pushed
the
change-backport-nominations
branch
from
c347fd8 to
63ae02e
Compare
Kobzol
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backport nominations were confusing so we decided to turn them into suggestions for reviewers and author of a PR fixing a regression. The idea is to raise awareness on patches fixing P-high/P-critical regressions but at the same time not make it look like a mandatory decision for T-compiler to take.
After this patch, I will modify the template that creates Zulip topics for backport nominations. For example it could look like this:
(visual representation)
(
@user1, @user2, @user3) are PR author and reviewers.As per Zulip discussion.