Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize in orphan check #104

Open
nikomatsakis opened this issue Oct 11, 2023 · 2 comments · Fixed by rust-lang/rust#117164
Open

Normalize in orphan check #104

nikomatsakis opened this issue Oct 11, 2023 · 2 comments · Fixed by rust-lang/rust#117164
Assignees
@lcnr
Labels
roadmap-tracking-issue Tracks an item on our types team roadmap.
Milestone
Early 2024

Comments

@nikomatsakis
Copy link
Contributor

No description provided.

@nikomatsakis nikomatsakis converted this from a draft issue Oct 11, 2023
@nikomatsakis nikomatsakis added this to the Early 2024 milestone Oct 11, 2023
@nikomatsakis nikomatsakis added the roadmap-tracking-issue Tracks an item on our types team roadmap. label Oct 11, 2023
@lcnr
Copy link
Contributor

lcnr commented Dec 4, 2023

Update: WIP PR by @fmease in rust-lang/rust#117164

@fmease fmease mentioned this issue Feb 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 26, 2024
@bors
Auto merge of rust-lang#117164 - fmease:orphan-norm, r=<try>
575e416 
Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

Fixes rust-lang#99554, fixes rust-lang/types-team#104.

Supersedes rust-lang#100555.

r? lcnr
@fmease fmease mentioned this issue Apr 30, 2024
Open
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 30, 2024
@bors
Auto merge of rust-lang#117164 - fmease:orphan-norm, r=lcnr
f705de5 
Lazily normalize inside trait ref during orphan check & consider ty params in rigid alias types to be uncovered

Fixes rust-lang#99554, fixes rust-lang/types-team#104.
Fixes rust-lang#114061.

Supersedes rust-lang#100555.

Tracking issue for the future compatibility lint: rust-lang#124559.

r? lcnr
@fmease
Copy link
Member

fmease commented Apr 30, 2024

We now normalize during orphanck and treat ty params in rigid alias tys to be uncovered.

However, for projections specifically, we don't emit a hard error but just a future-incompat dont-report-in-deps warn-by-default lint (tracked in rust-lang/rust#124559).

github-actions bot pushed a commit to rust-lang/miri that referenced this issue May 3, 2024
@bors
Auto merge of #117164 - fmease:orphan-norm, r=lcnr
b1e3f7b 
Lazily normalize inside trait ref during orphan check & consider ty params in rigid alias types to be uncovered

Fixes #99554, fixes rust-lang/types-team#104.
Fixes #114061.

Supersedes #100555.

Tracking issue for the future compatibility lint: #124559.

r? lcnr
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue May 18, 2024
@bors
Auto merge of #117164 - fmease:orphan-norm, r=lcnr
8435d14 
Lazily normalize inside trait ref during orphan check & consider ty params in rigid alias types to be uncovered

Fixes #99554, fixes rust-lang/types-team#104.
Fixes #114061.

Supersedes #100555.

Tracking issue for the future compatibility lint: #124559.

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcnr lcnr

Labels
roadmap-tracking-issue Tracks an item on our types team roadmap.
Projects
types team roadmap
Status: No status
Milestone
Early 2024
3 participants
@nikomatsakis @fmease @lcnr