Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projections in impl headers #91

Closed
lcnr opened this issue May 8, 2023 · 1 comment
Closed

projections in impl headers #91

lcnr opened this issue May 8, 2023 · 1 comment
Labels
deep-dive-proposal Proposal for a deep-dive discussion meeting T-types Add this label so rfcbot knows to poll the types team

Comments

@lcnr
Copy link
Contributor

lcnr commented May 8, 2023 •
edited
Loading

Summary

Talk about rust-lang/rust#107263 and rust-lang/rust#99554 and whether we want to change the orphan check to run after normalization.

This impacts both inherent and trait impls

Rationale

Have to make progress on rust-lang/rust#99554 and fixing this without normalizing as part of the orphan check results in too much breakage.
@lcnr lcnr added deep-dive-proposal Proposal for a deep-dive discussion meeting T-types Add this label so rfcbot knows to poll the types team labels May 8, 2023
@lcnr lcnr mentioned this issue May 8, 2023
Open
@lcnr
Copy link
Contributor Author

lcnr commented Oct 23, 2023

discussed during the in person meetup, we will go ahead and normalize before the orphan check. The PR doing so will require an FCP.

@lcnr lcnr closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deep-dive-proposal Proposal for a deep-dive discussion meeting T-types Add this label so rfcbot knows to poll the types team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lcnr