Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chalk support from Rust #93

Closed
1 of 3 tasks
compiler-errors opened this issue Jun 15, 2023 · 4 comments
Closed
1 of 3 tasks

Remove chalk support from Rust #93

compiler-errors opened this issue Jun 15, 2023 · 4 comments
Labels
final-comment-period The FCP has started, most (if not all) team members are in agreement major-change A major change proposal T-types Add this label so rfcbot knows to poll the types team to-announce Announce this issue on triage meeting

Comments

@compiler-errors
Copy link
Member

Proposal

As far as I'm aware, the Chalk compiler is deprecated1. My understanding is that T-types will continue maintaining it for rust-analyzer, but we have no plans to continue integrating it into rustc and it's a bit of a burden on the compiler due to the interning layer from chalk <=> rustc and the specific workarounds that live in the compiler to accomodate for the chalk solver.

Mentors or Reviewers

I can implement the removal. The code should be very easy to review since it's just a bunch of code going away.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A types team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Types team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

Not sure if this should be a full-fledged FCP. If so, I can open one on the removal PR.

Footnotes

  1. https://blog.rust-lang.org/2023/01/20/types-announcement.html#formalizing-the-rust-type-system ↩
@compiler-errors compiler-errors added major-change A major change proposal T-types Add this label so rfcbot knows to poll the types team labels Jun 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/types

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 15, 2023
@BoxyUwU
Copy link
Member

BoxyUwU commented Jun 15, 2023

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 15, 2023
@jackh726
Copy link
Member

/concern

As I mentioned on zulip I do think the Chalk integration is still useful, particularly with my experimentation with associated types.

Can you say more about exactly how it's a burden to maintain? New features and such don't need to be implemented in the Chalk integration code. Is there some specific changes or refactoring that we can't do because of the chalk integration code? (That can't simply just be unimplemented!()?

@lcnr
Copy link
Contributor

lcnr commented Jul 3, 2023

closing as accepted https://rust-lang.zulipchat.com/#narrow/stream/326132-t-types.2Fmeetings/topic/2023-07-03.20planning.20meeting/near/372030757

@lcnr lcnr closed this as completed Jul 3, 2023
@compiler-errors compiler-errors mentioned this issue Jul 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 4, 2023
@bors
Auto merge of rust-lang#113303 - compiler-errors:yeet-chalk, r=lcnr
cd68ead 
Remove chalk support from the compiler

Removes chalk (`-Ztrait-solver=chalk`) from the compiler and prunes any dead code resulting from this, mainly:
* Remove the chalk compatibility layer in `compiler/rustc_traits/src/chalk`
* Remove the chalk flag `-Ztrait-solver=chalk` and its `TraitEngine` implementation
* Remove `TypeWellFormedFromEnv` (and its many `bug!()` match arms)
* Remove the chalk migration mode from compiletest
* Remove the `chalkify` UI tests (do we want to keep any of these, but migrate them to `-Ztrait-solver=next`??)

Fulfills rust-lang/types-team#93.

r? `@jackh726`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
final-comment-period The FCP has started, most (if not all) team members are in agreement major-change A major change proposal T-types Add this label so rfcbot knows to poll the types team to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@compiler-errors @BoxyUwU @lcnr @jackh726 @rustbot