-
Notifications
You must be signed in to change notification settings - Fork 59
Update discriminant-elision optimization on Option-like enums #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This still does not specify, though, that transmuting between e.g. EDIT: Oh I see, that RFC pretty much fixes the |
Co-Authored-By: Ralf Jung <post@ralfj.de>
Co-Authored-By: Ralf Jung <post@ralfj.de>
Co-Authored-By: Ralf Jung <post@ralfj.de>
Co-Authored-By: Ralf Jung <post@ralfj.de>
The last commit hyperlinks everything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR updates the discriminant-elision optimization on option-like enums with the semantics specified in rust-lang/rust#60300
The main change is requiring that option-like enums do not have any explicit
#[repr(...)]
attributes.