Wrong rls gets started on Windows

[lnicola]

I have the nightly-msvc and nightly-gnu toolchains installed, with the default set to msvc. When I start VS Code, the extension starts rls from nightly-x86_64-pc-windows-gnu, which leads to weird issues later.

> rustup show
Default host: x86_64-pc-windows-gnu

installed toolchains
--------------------

nightly-x86_64-pc-windows-gnu
nightly-x86_64-pc-windows-msvc (default)

active toolchain
----------------

nightly-x86_64-pc-windows-msvc (default)
rustc 1.22.0-nightly (b7960878b 2017-10-18)

> rustup which rls
C:\Users\User\.rustup\toolchains\nightly-x86_64-pc-windows-msvc\bin\rls.exe

[lnicola]

The issue seems to be that CONFIGURATION.channel gets initialized to nightly:

>rustup run nightly-msvc rustc -vV
rustc 1.22.0-nightly (b7960878b 2017-10-18)
binary: rustc
commit-hash: b7960878ba77124505aabe7dc99d0a898354c326
commit-date: 2017-10-18
host: x86_64-pc-windows-msvc
release: 1.22.0-nightly
LLVM version: 4.0

>rustup run nightly rustc -vV
rustc 1.22.0-nightly (b7960878b 2017-10-18)
binary: rustc
commit-hash: b7960878ba77124505aabe7dc99d0a898354c326
commit-date: 2017-10-18
host: x86_64-pc-windows-gnu
release: 1.22.0-nightly
LLVM version: 4.0

[lnicola]

See also rust-lang/rustup#1256.

[Xanewok]

Should be fixed by #173.

[lnicola]

Not really. #173 makes the toolchain configurable, but the default behavior is still surprising.

[nrc]

This would be addressed by #179 Closing in favour of that issue.