Use the user's default toolchain #180
Conversation
|
In #179 I propose a slightly different approach - using the current Rustup default as the default. So if the user is using stable, they'll get stable and if they're using nightly they'll get nightly. I'd prefer not to always use stable as default since for users with both nightly and stable toolchains, they'll get a significantly better experience with nightly. |
|
Ah! That makes total sense. I'll try to update this PR later this week. |
|
I changed the PR to look up for the default toolchain. Not sure how it fits with rust-lang/rustup#1279 (comment), though. Also not sure why the build on Travis is failing, it builds just fine for me. |
| @@ -170,7 +170,7 @@ | |||
| }, | |||
| "rust-client.channel": { | |||
| "type": "string", | |||
| "default": "nightly", | |||
| "default": "default", | |||
There was a problem hiding this comment.
I think you can use null rather than "default"
| } catch (e) { | ||
| console.log(e); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you move this code to rustup.rs?
There was a problem hiding this comment.
I thought about moving it there but most of the code in rustup.ts relies on the RLSConfiguration object being already initialised, and is async. I thought this code would be inconsistent with the rest of the code there. I have no problem moving it there though.
There was a problem hiding this comment.
It looks like you're using RLSConfiguration here too though? I don't think that whether the code is sync or async should make too much difference as to where it should live.
|
Not sure why Travis is failing. Looks like a TypeScript compilation error, but it's not in a place that I would have thought your code should affect. |
|
The test failure is weird - I see it locally too, but that code hasn't changed for months. I guess a library changed or something. Anyway, not your problem :-) |
Since Rust 1.21 the RLS can be installed from the stable channel, which means that most new users can install the RLS with the toolchain they get by default via rustup.
|
While working on this I found several edge cases and I have not enough time to handle them at the moment. I'm closing this PR for now. |
* some clippy-suggested improvements * match instead of if, pattern simplification
Since Rust 1.21 the RLS can be installed from the stable channel.
Switching to use the stable channel by default would let people who
prefer to depend only on the stable compiler to have nightly installed
for one less thing.