This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Remove old rls.findImpls command
#564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was used before LSP has considered (and now stabilised) a 'go to implementation' request. Handling this via LSP, even at the cost of command disappearing from the context menu [1], is preferred than using a global command. We'd have to maintain an extra mapping and guess which RLS server is responsible for the file for which a request has been made. This is hacky and not guaranteed to be correct; meanwhile we get errors in multi-root workspaces whenever we open more than one folder due to each instance trying to register a global command under the same identifier. The clean solution is to remove this extra command and use the standard Go to Implementation (under Go > Go to Implementation [Ctrl + F12]) while we wait for the user configurable menus [2] to land. [1]: microsoft/vscode#54317 [2]: microsoft/vscode#9285
|
@Xanewok Hi. Would you like to merge this patch recently? |
|
I'd love to but I'm afraid that losing the menu entry might cause an uproar, similar to dropping the |
|
Let's merge this - hopefully there won't be angry users this time 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used before LSP has considered (and now stabilised)
a 'go to implementation' request. Handling this via LSP,
even at the cost of command disappearing from the context menu 1,
is preferred than using a global command. We'd have to maintain an
extra mapping and guess which RLS server is responsible for the file
for which a request has been made. This is hacky and not guaranteed
to be correct; meanwhile we get errors in multi-root workspaces
whenever we open more than one folder due to each instance trying to
register a global command under the same identifier.
The clean solution is to remove this extra command and use the standard
Go to Implementation (under Go > Go to Implementation [Ctrl + F12])
while we wait for the user configurable menus 2 to land.
Addresses #560 (doesn't fix unavailable commands in second directory)
Closes #437.