-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Borrowing arguments ("Alan writes a web framework") #101
Conversation
A big plus one on this one. Not being able to describe the trait of async functions with non-static lifetimes in the arguments is by far the biggest pain in async rust right now. I'm excited to see how GATs improve this situation, but that's about solutions. Whole web framework designs might be different if mutable borrows could be passed into handler functions instead of owned types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few comments based on a quick read! The short version is that more examples would help bring the story to life for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's definitely some really great insights here, but it looks like it's missing a bit of detail to really make the lessons obvious. Adding example errors and a bit more explanation of what exactly was confusing will go a long way.
("It was like this when I got here")
You're missing one more problem here: the final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is pretty good now! Let me review the outstanding comments, but I might just merge.
This PR contains a write-up of my experiences from #78 (comment)
There is a bit of solutionising towards the end. I can rip that out if you want:
It's also super-trimmed-down compared to my full experiences, and we could probably flesh out the morals a bit better.