Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add story of Alan running in trouble with large stack allocations #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add story of Alan running in trouble with large stack allocations #38
Changes from all commits
16a242b
5657f51
41f6e06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just pins things on the "async stack" automatically for you. The futures-rs version however does that too after I implemented rust-lang/futures-rs#1873 . The tokio version mainly goes a little bit further and avoids the
FusedFuture
requirements based off the ideas in rust-lang/futures-rs#1989.I don't any version of the
select!
macro would resolve the issue on its own - one will always need an explicitBox
to decouple theFuture
s. Only something likeFuturesUnordered
or other sub-executors will do it automatically.Still surprised that the whole thing took 4Gb and could be fixed by improving one select. While it's known that generators can grow exponentially in size it seems to take a while to get to 4Gb 😯