Update Team Data #1030
Merged
Update Team Data #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @XAMPPRocky @Manishearth! This commit was problematic for translation, because it updates the content of some strings without changing the string key, for example the value of Pontoon doesn't seem to be able to detect this kind of changes, and would assume that existing translations for the old strings can still be used, until someone happens to notice the mismatch. We should probably have some mechanism to check against updating strings without changing the key accidentally. WDYT? |
|
Raised an issue in #1091. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the team data based on
cargo run dump-websitein https://github.com/rust-lang/team