Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added additional resources to learn.rust-lang.org. #1446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ckaran
Copy link

@ckaran ckaran commented Feb 16, 2021

Relates to issue #1433.

Added 3 additional resources to learn.rust-lang.org in their own section:

NOTE! This commit requires additional work; I am not fluent in any
language other than US English, and so haven't attempted to add translations.
native speakers that are able to make the necessary changes are required
here.

Added 3 additional resources to learn.rust-lang.org in their own section:
- https://rust-lang.github.io/api-guidelines
- https://rust-unofficial.github.io/patterns
- https://rust-lang-nursery.github.io/rust-cookbook

**NOTE!** This commit requires additional work; I am not fluent in any
language other than US English, and so haven't attempted to add translations.
native speakers that are able to make the necessary changes are required
here.
@ckaran ckaran requested a review from a team as a code owner February 16, 2021 15:07
@Manishearth
Copy link
Member

So I don't think this should be a separate section, we should just add more buttons to the existing long list. And as I mentioned before, we do not link to unofficial resources on this website.

@ckaran
Copy link
Author

ckaran commented Feb 16, 2021

So I don't think this should be a separate section, we should just add more buttons to the existing long list.

Which one?

And as I mentioned before, we do not link to unofficial resources on this website.

OK, I misunderstood what you meant then. Do you mean that you want me to copy the external documentation to some internal location? Or should the links be placed somewhere different?

@Manishearth
Copy link
Member

OK, I misunderstood what you meant then. Do you mean that you want me to copy the external documentation to some internal location? Or should the links be placed somewhere different?

No, I'm saying that the rust-unofficial.github.io content cannot be linked here. The other two are fine, rust-lang and rust-lang-nursery are official sources.

Which one?

I was going to suggest the "read the core documentation" section but that's not quite right. A new "additional resources" section may make more sense.

cc @skade who might have ideas on how best to surface this

@skade
Copy link
Contributor

skade commented Feb 16, 2021

Phew, I guess this merits a new section. There's also upcoming things like the async book and such that might not fit the current.

@Manishearth
Copy link
Member

After some discussion it does seem like cookbook is not being maintained as much, and I'm unsure about api-guidelines. @KodrAus @rust-lang/libs can y'all:

  • give me an idea whether the libs team is maintaining either of these resources, and if so how maintained they are
  • let us know if you'd like either of these resources to be listed on http://www.rust-lang.org/learn

(In general we ought to defer to the teams on site content, sorry for the misleading signals, @ckaran )

@ckaran
Copy link
Author

ckaran commented Feb 18, 2021

(In general we ought to defer to the teams on site content, sorry for the misleading signals, @ckaran )

Makes complete sense to me! I'm just trying to be helpful, especially as rust can have a steep learning curve.

I just thought of another good resource that, while not official, is run by someone well-known within the community: @dtolnay's proc-macro-workshop. The issue is that it is yet another resource that is not official. Maybe what is needed is a whole new section: 'Additional UNOFFICIAL Resources', with a big warning that those resources aren't maintained by the rust team, and as such may go away or be unhelpful in some way.

Getting back to this PR in particular, I'm going to hold off on making any more changes until some of the other questions are resolved. I don't like churn in documentation, it wrecks my muscle memory when I'm looking for something, and I suspect others are the same. Once the questions are resolved, I can modify this PR.

@skade
Copy link
Contributor

skade commented Feb 18, 2021

I just thought of another good resource that, while not official, is run by someone well-known within the community: @dtolnay's proc-macro-workshop. The issue is that it is yet another resource that is not official. Maybe what is needed is a whole new section: 'Additional UNOFFICIAL Resources', with a big warning that those resources aren't maintained by the rust team, and as such may go away or be unhelpful in some way.

There's a strict policy to not link to unofficial resources on the website. They still need vetting and tracking and it's impossible to untangle yourself from the endorsement.

@ckaran
Copy link
Author

ckaran commented Feb 19, 2021

There's a strict policy to not link to unofficial resources on the website. They still need vetting and tracking and it's impossible to untangle yourself from the endorsement.

What about asking the authors if they would donate the material to the internal repository? At that point, the rust team would have complete control over the material and could vet it. The original authors would need to issue PRs to make updates to the material, but that shouldn't be too big a hurdle. It might even help bootstrap getting the documentation team restarted by simply asking if really good authors would be a part of it...

@Manishearth
Copy link
Member

You misunderstand; this is not a matter of control, this is a matter of quality. For a resource to be official it needs to be maintained, and maintained by us, by a functional team with goals. The "by us" part is not the hard part here, it's necessary but far from sufficient. We do not currently have the bandwidth to vet and maintain these projects. We're working on growing it, but it's more of an organizational problem than simply a lack of documentation-minded people. Documentation is a cross-cutting concern and is as such tricky to make work in an open source organization.

This is a symptom of a bigger problem, and will not be solved by pulling in more resources to maintain.

@ckaran
Copy link
Author

ckaran commented Feb 19, 2021

I see. In that case, there is very little that can be done currently. The API guidelines should probably go in, but if the cookbook isn't as well maintained as the other parts, then it should stay out. The rest can't go in at all.

Where should the API guidelines go? In their own section?

@Manishearth
Copy link
Member

Whether they should go in, and where they should go, is up to the libs team, since it's really not clear if the API guidelines are strongly maintained.

@ckaran
Copy link
Author

ckaran commented Feb 22, 2021

@Manishearth OK, so should I close out this PR entirely, and log an issue with one of the teams? If so, which team?

@Manishearth
Copy link
Member

Doesn't matter if the PR is closed, I have already tagged the libs team here with my questions

@AliSajid
Copy link
Contributor

Rust team, the libs team has not responded. I can't say about api-guidelines but the cookbook is definitely outdated. I suggest we close this out and maybe create a new issue to track adding additional official resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants