Skip to content

Conversation

@dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 9, 2024

Apparently the Rust version pre-installed on these runners fluctuates non-monotonically as a new image is rolled out.

#1905 originally got built by Rust 1.75. That's why it failed CI and necessitated #1906.

Then #1909, which requires Rust 1.75, obviously got built by 1.75.

Then the second build of #1905 got built by 1.74 (as a merge commit which includes #1909), which failed CI.

error[E0562]: `impl Trait` only allowed in function and inherent method return types, not in trait method return types
  --> src/cache.rs:16:19
   |
16 |     fn fetch() -> impl Future<Output = Result<Self, Box<dyn Error + Send + Sync>>> + Send;
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #91611 <https://github.com/rust-lang/rust/issues/91611> for more information

error[E0706]: functions in traits cannot be declared `async`
  --> src/cache.rs:17:5
   |
17 |     async fn get(cache: &Cache<Self>) -> Self {
   |     -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |     |
   |     `async` because of this
   |
   = note: `async` trait functions are not currently supported
   = note: consider using the `async-trait` crate: https://crates.io/crates/async-trait
   = note: see issue #91611 <https://github.com/rust-lang/rust/issues/91611> for more information

@Manishearth Manishearth merged commit 4797b87 into rust-lang:master Jan 9, 2024
@dtolnay dtolnay deleted the stable branch January 9, 2024 23:55
@dtolnay dtolnay mentioned this pull request Jan 15, 2024
@senekor
Copy link
Contributor

senekor commented Sep 28, 2024

@Thompson1985 please stop, I and others are getting pinged for these. If you like a PR, you can add emoji reactions. Those don't trigger notifications I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants