embedded: add text, icons, testimonials and friends section #62
Conversation
templates/what/embedded.hbs
Outdated
| <div class="four columns"> | ||
| <div class="domain-icon"> | ||
| <!-- TODO replace this icon; this is just a sample --> | ||
| <img src="https://image.flaticon.com/icons/svg/63/63794.svg" width="128" alt="A microscope"/> |
There was a problem hiding this comment.
We discussed what icons would fit with the Rust attributes and came up with these ideas (e.g. microcospe) after some brainstorming; suggestions are welcome.
The icon I included here is the first thing I found on the internet; we likely will want to pick something that has an appropriate license, or have the icon made.
There was a problem hiding this comment.
these looks pretty great, i have already attributed the page you used in the footer, https://www.flaticon.com/, so i think we're actually all set?
There was a problem hiding this comment.
Alright, then we can use these icons.
templates/what/embedded.hbs
Outdated
| <h3><a href="#">Company #3</a></h3> | ||
| "Cargo is pretty much worth it to switch by itself." | ||
|
|
||
| <!-- Friends section --> |
There was a problem hiding this comment.
We probably want some text or blank space between the testimonials and the friends section. It looks a bit cluttered right now, IMO.
There was a problem hiding this comment.
if you throw this in a <section> the spacing should be fixed :)
| <h2>Embedded Rust in production</h2> | ||
| </header> | ||
|
|
||
| <!-- Testimonials section --> |
There was a problem hiding this comment.
I have included only two testimonials but there are two companies that might be able to provide two more testimonials. We discussed this section and agreed that having a carousel of testimonials like this one would save vertical space in case we end up with several testimonials.
That discussion was before I saw the testimonial style that's being used in the front page (and which I copy pasted here).
There was a problem hiding this comment.
yeah i just did something so that it looked vaguely ok for the moment :) i'm happy to add a carousel if you think you'd prefer!
There was a problem hiding this comment.
I'd love to see how a carousel would fit with the rest of the page.
| @@ -1,116 +1,245 @@ | |||
| {{#*inline "page"}} | |||
|
|
|||
There was a problem hiding this comment.
can you add a header that says "Embedded Devices" here? similar to this: https://github.com/rust-lang/wubwub/blob/master/templates/policies/media-guide.hbs#L3-L7
templates/what/embedded.hbs
Outdated
| <div class="four columns"> | ||
| <div class="domain-icon"> | ||
| <!-- TODO replace this icon; this is just a sample --> | ||
| <img src="https://image.flaticon.com/icons/svg/63/63794.svg" width="128" alt="A microscope"/> |
There was a problem hiding this comment.
let's not hard code the width :) i can handle that with some css :)
templates/what/embedded.hbs
Outdated
| <!-- TODO replace this icon; this is just a sample --> | ||
| <img src="https://image.flaticon.com/icons/svg/908/908319.svg" width="128" alt="A RAM stick"/> | ||
|
|
||
| <h5>Flexible memory management</h5> |
There was a problem hiding this comment.
could you make these h3s? if you want them smaller we can handle that in CSS :)
templates/what/embedded.hbs
Outdated
| <img src="https://image.flaticon.com/icons/svg/1/1615.svg" width="128" alt="DIP-6 package"/> | ||
|
|
||
| <a href="https://japaric.github.io/discovery"> | ||
| <h5>The Discovery book</h5> |
templates/what/embedded.hbs
Outdated
| <h3><a href="#">Company #3</a></h3> | ||
| "Cargo is pretty much worth it to switch by itself." | ||
|
|
||
| <!-- Friends section --> |
There was a problem hiding this comment.
if you throw this in a <section> the spacing should be fixed :)
japaric
changed the title
|
@ashleygwilliams I think I addressed all your comments. Let me know if I missed something! |
|
cool! i'm going to merge and do a little bit of CSS but this is definitely a pass for stage 1! thanks so much |
The layout is the one we discussed during Rust All Hands plus a friends section at the end.
This is what it looks like so far:
cc @jamesmunns