Add a Visitor implementation to Marker
#159
Labels
A-marker-utils
Area: Utility functions usually provided in `marker_utils` or `marker_api`
C-enhancement
Category: New feature or request
Milestone
Comments
xFrednet
added
C-enhancement
bors bot
added a commit
that referenced
this issue
Jul 9, 2023
161: Utils: Setup `marker_utils` project and add a `Visitor` (First clean dogfood) r=xFrednet a=xFrednet This PR is an important milestone. It adds the new `marker_utils` crate with a new `Visitor` trait. This trait is then directly used to traverse the entire AST in the `marker_adapter` crate. And finally, dogfood, or better say a clean dogfood. It just passes, able to translate everything. I don't quite know how to feel about this, tbh. The number of changes sadly exploded, sorry if someone actually looks at this 😅 --- cc: #159 I think the design still needs some small adjustments, like being able to limit the scope of what is being visited etc. Co-authored-by: xFrednet <xFrednet@gmail.com>
|
The basic implementation is done, but I would like to add more options, to allow the user to specify if bodies should be visited. This could be done with constant generics or a simple function in the It would also be nice to have a closure-based visitor, for simple use cases, like the one Clippy provides: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The basic job of a
Visitor, is to visit everything inside a given scope, in our case, a part of the AST. This definition still gives a lot of room for interpretation or better say flexibility.The granularity of the visit can vary. I'm thinking of potentially supporting different types of granularity:
A different factor is how bodies are handled. Bodies can contain further items and expressions. This can be relevant, depending on the goal of the visitor. Most lints in Clippy, only visit one body and don't resolve inner bodies.
Another thing to consider, is how the implementor code will be called. Rustc's implementation calls a trait
Visitorwhile Clippy often uses a visitor calling a closure: for_each_expr.This is way more complicated than I thought at first. This will be fun.
Once this is implementation, I would like to use the visitor in
marker_adapterto ensure that everything is visited correctly (Currently it skips quite a few nodes 😅 )The text was updated successfully, but these errors were encountered: