Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent naming fn pat() vs fn pattern() #297

Closed
Veetaha opened this issue Oct 19, 2023 · 0 comments · Fixed by #309
Closed

Use consistent naming fn pat() vs fn pattern() #297

Veetaha opened this issue Oct 19, 2023 · 0 comments · Fixed by #309
Assignees
Labels
A-api Area: Stable API E-good-first-issue Participation: Good for newcomers I-api-break Issue: This change will break the public API
Milestone

Comments

@Veetaha
Copy link
Contributor

Veetaha commented Oct 19, 2023

Some methods in marker_api are called pat(), but there are few that are called pattern. We need to make the naming consistent. Maybe move these methods under a trait and/or add a custom lint to marker_lints that checks that we don't call the term "pattern" inconsistently.

@Veetaha Veetaha added the S-needs-triage Status: This issue needs triage label Oct 19, 2023
@xFrednet xFrednet added A-api Area: Stable API E-good-first-issue Participation: Good for newcomers I-api-break Issue: This change will break the public API and removed S-needs-triage Status: This issue needs triage labels Oct 21, 2023
@xFrednet xFrednet added this to the v0.4.0 milestone Oct 21, 2023
@xFrednet xFrednet self-assigned this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-api Area: Stable API E-good-first-issue Participation: Good for newcomers I-api-break Issue: This change will break the public API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants