Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Rename CallExpr::operand -> CallExpr::func; *::pattern -> *::pat #309

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Nov 14, 2023

Some smaller breaking changes before v0.4.0 probably best summarized by the changelog entry:

  • Renamed CallExpr::operand to CallExpr::func
  • Renamed RefPat::pattern() -> RefPat::pat()
  • Renamed OrPat::patterns() -> RefPat::pats()

Yeah, and that's it :D


I also moved the semver check higher in our CI file. I thought about making it the first item, but I feel like the others are still more important and should be the first visible CI checks. Having semver higher up is already a nice change :)


Closes #297

Closes #295

@xFrednet xFrednet added C-enhancement Category: New feature or request A-api Area: Stable API I-api-break Issue: This change will break the public API labels Nov 14, 2023
@xFrednet xFrednet added this to the v0.4.0 milestone Nov 14, 2023
Copy link
Contributor

@Veetaha Veetaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend adding "Closes #297" and "Closes #295" to the PR description to make the issues auto-closed when PR is merged

@xFrednet
Copy link
Member Author

Good call, I forgot about that. Thanks!

@xFrednet xFrednet added this pull request to the merge queue Nov 14, 2023
Merged via the queue into rust-marker:master with commit 6a4bb90 Nov 14, 2023
22 of 23 checks passed
@xFrednet xFrednet deleted the 295-297-break-break-break branch November 14, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-api Area: Stable API C-enhancement Category: New feature or request I-api-break Issue: This change will break the public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent naming fn pat() vs fn pattern() Rename CallExpr::operand to CallExpr::func
2 participants