-
Notifications
You must be signed in to change notification settings - Fork 11
API, Rustc: Rework spans (and fix a few errors) #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
reviewed
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done 👍
Co-authored-by: Veetaha <gersoh3@gmail.com>
0473103
to
9a5fe9c
Compare
Veetaha
approved these changes
Aug 22, 2023
Thank you for the review! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-api
Area: Stable API
A-driver
Area: Driver or something related to the internal working of a driver.
C-enhancement
Category: New feature or request
D-rustc-driver
Driver: Rustc Driver
I-panic
Issue: Some part of the linter panicked unexpectedly
S-waiting-on-review
Status: Awaiting review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spans are a fundamental part of linting in Rust. The previous implementation of spans in Marker were hacked together, with me always adding something new when it was needed. This PR reworks spans from the ground up.
The implementation is inspired by rustc's
Span
and connected data structures.While testing, I also found a few ICEs and mistakes, that were fixed as well. The short summary:
Span
s are now coolAn awesome effect of this change is that the
Debug
format implementation of spans looks a lot better now, like this:cc: #175