API: Rename QuestionMarkExpr -> TryExpr (Breaking change)
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `?` operator is officially called the *ErrorPropagationExpression* in [Rust's grammar](https://doc.rust-lang.org/reference/expressions/operator-expr.html#the-question-mark-operator). However, I've rarely seen people actually call it by that name. Even the documentation doesn't call it that after the grammar definition. Before, I've called it the *QuestionMarkOperator*, but this name feels a bit off, as that describes how it's written, but not what it does. I have the impression, that the community commonly calls this operator the *Try* operator. That's at least the name I would use and what I've seen in a few blog posts. This change is open for discussion. If you have any thoughts, please share them! :)
xFrednet
added
A-api
|
Given that there is an unstable |
Veetaha
reviewed
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
?operator is officially called the ErrorPropagationExpression in Rust's grammar. However, I've rarely seen people actually call it by that name. Even the documentation doesn't call it that after the grammar definition.Before, I've called it the QuestionMarkOperator, but this name feels a bit off, as that describes how it's written, but not what it does. I have the impression, that the community commonly calls this operator the Try operator. That's at least the name I would use and what I've seen in a few blog posts.
This change is open for discussion. If you have any thoughts, please share them! :)