Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Rename AstContext -> MarkerContext (Let's break everything 💥) #256

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

xFrednet
Copy link
Member

This PR has two gigantic breaking changes:

If anyone uses Marker right now, they will definitely notice this change. But I believe this is worth it and still acceptable at this point.

@xFrednet xFrednet added C-enhancement Category: New feature or request A-api Area: Stable API I-api-break Issue: This change will break the public API labels Sep 25, 2023
@xFrednet xFrednet added this to the v0.3.0 milestone Sep 25, 2023
@xFrednet xFrednet changed the title API: Rename AstContext -> MarkerContext (Let's break everything) API: Rename AstContext -> MarkerContext (Let's break everything 💥) Sep 25, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
marker_api/src/lib.rs Show resolved Hide resolved
@xFrednet
Copy link
Member Author

I've done a small update of Marker's readme, I hope this won't conflict with #255

@Veetaha I've stumbled across the ## Contributing section again during this update. In this regard, I wanted to ask if you remember running into any trouble when you got started with contributing?

@Veetaha
Copy link
Contributor

Veetaha commented Sep 26, 2023

The only trouble that I had was figuring out that I need to add this to the RA vscode config to make it resolve the private rustc crates

{
    "rust-analyzer.rustc.source": "discover"
}

@xFrednet
Copy link
Member Author

Nice catch! I've updated the documentation (What a productive way to procrastinate on some other things I should actually work on ^^)

@xFrednet xFrednet added this pull request to the merge queue Sep 26, 2023
Merged via the queue into rust-marker:master with commit c238fb7 Sep 26, 2023
15 checks passed
@xFrednet xFrednet deleted the 243-lets-break-everything branch September 26, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-api Area: Stable API C-enhancement Category: New feature or request I-api-break Issue: This change will break the public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants