-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Rename AstContext
-> MarkerContext
(Let's break everything 💥)
#256
API: Rename AstContext
-> MarkerContext
(Let's break everything 💥)
#256
Conversation
AstContext
-> MarkerContext
(Let's break everything)AstContext
-> MarkerContext
(Let's break everything 💥)
9fa9dda
to
051736b
Compare
051736b
to
6fd9b37
Compare
I've done a small update of Marker's readme, I hope this won't conflict with #255 @Veetaha I've stumbled across the |
The only trouble that I had was figuring out that I need to add this to the RA vscode config to make it resolve the private rustc crates {
"rust-analyzer.rustc.source": "discover"
} |
Nice catch! I've updated the documentation (What a productive way to procrastinate on some other things I should actually work on ^^) |
This PR has two gigantic breaking changes:
AstContext
was renamed toMarkerContext
(See [Discussion] RenameAstContext
->MarkerContext
or something similar? #243)Span
and related structs have been moved to the newmarker_api::span
moduleIf anyone uses Marker right now, they will definitely notice this change. But I believe this is worth it and still acceptable at this point.