Chore: Update Deps and increase MSRV to 1.70 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
force-pushed
the
000-update-deps
branch
2 times, most recently
from
1fe06fa
to
5642cae
Compare
xFrednet
changed the title
|
I believe the MSRV increase from 1.66 to 1.70 should be safe, since we distribute precompiled binaries now. We have several dependencies, that have 1.70 (release 2023-06-01) as their MSRV. I still listed this change, in the changelog under the breaking changes section. |
Veetaha
approved these changes
Dec 26, 2023
Cargo.toml
Outdated
| ui_test = "0.21.2" | ||
| visibility = "0.1.0" | ||
| yansi = "1.0.0-rc.1" | ||
| yansi = "1.0.0-gamma" |
There was a problem hiding this comment.
1.0.0-rc.1 is a more recent one (versions)
| @@ -44,9 +44,9 @@ marker_utils = { path = "./marker_utils", version = "0.5.0-dev" } | |||
| bumpalo = "3.14" | |||
| camino = { version = "1.1", features = ["serde1"] } | |||
| cargo_metadata = "0.18" | |||
| clap = { version = "=4.3.24", features = ["string", "derive"] } | |||
There was a problem hiding this comment.
I wonder why it was pinned
There was a problem hiding this comment.
Clap increased the minimal rust version in newer releases. The pin was me trying to keep rust 1.66 as the minimal version. Now we can just use the newest version again.
xFrednet
force-pushed
the
000-update-deps
branch
2 times, most recently
from
e5be5be
to
c3b900e
Compare
xFrednet
force-pushed
the
000-update-deps
branch
from
c3b900e
to
a745a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to say, just some prep for the next release.