Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Send and Sync to NearestNeighbourIndex box. #176

Closed
wants to merge 2 commits into from

Conversation

Christoff-Zulzi
Copy link

LinearSearch, KdTree and BallTree are all Send + Sync. Allows for async use of the models.

Justification: LinearSearch, KdTree and BallTree are all Send + Sync.
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #176 (a11b682) into master (870107f) will increase coverage by 0.07%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   55.37%   55.44%   +0.07%     
==========================================
  Files          96       96              
  Lines        8918     8921       +3     
==========================================
+ Hits         4938     4946       +8     
+ Misses       3980     3975       -5     
Impacted Files Coverage Δ
algorithms/linfa-nn/src/lib.rs 57.14% <ø> (ø)
algorithms/linfa-nn/src/linear.rs 43.75% <0.00%> (-1.71%) ⬇️
algorithms/linfa-nn/src/balltree.rs 54.33% <100.00%> (ø)
algorithms/linfa-nn/src/kdtree.rs 51.28% <100.00%> (+1.28%) ⬆️
...lgorithms/linfa-clustering/src/optics/algorithm.rs 48.53% <0.00%> (-0.29%) ⬇️
algorithms/linfa-nn/tests/nn.rs 78.04% <0.00%> (ø)
algorithms/linfa-kernel/src/lib.rs 60.21% <0.00%> (ø)
algorithms/linfa-logistic/src/lib.rs 69.55% <0.00%> (ø)
algorithms/linfa-pls/src/pls_generic.rs 69.64% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YuhanLiin
Copy link
Collaborator

The type Box<dyn 'a + Send + Sync + NearestNeighbourIndex<F>> is getting a bit long. Can you replace it with an internal type alias?

Copy link
Collaborator

@YuhanLiin YuhanLiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase this branch on top of the current master to get rid of the CI failure

@YuhanLiin
Copy link
Collaborator

Closed by #235

@YuhanLiin YuhanLiin closed this Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants