Fix max_n_iterations in k_means algorithm

[quettabit]

Issue

If we set max_n_iterations as i and if the algo hasn't converged based on tolerance at i-th iteration, it errors with KMeansError::NotConverged. Even if we don't set to a specific i and if it manages to reach 300-th iteration (the default), it would still error i think.

Fix

This patch fixes the issue and makes the behavior as expected from the already existing documentation. Also, have added a test.

[codecov-commenter]

Codecov Report

Base: 55.59% // Head: 55.61% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5ed1d28) compared to base (d3464d7).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   55.59%   55.61%   +0.01%     
==========================================
  Files          96       96              
  Lines        8951     8955       +4     
==========================================
+ Hits         4976     4980       +4     
  Misses       3975     3975              

Impacted Files	Coverage Δ
...gorithms/linfa-clustering/src/k_means/algorithm.rs	49.17% <77.77%> (+0.86%)	⬆️
algorithms/linfa-nn/src/kdtree.rs	48.64% <0.00%> (-1.36%)	⬇️
...rithms/linfa-clustering/src/k_means/hyperparams.rs	44.06% <0.00%> (-0.94%)	⬇️
algorithms/linfa-pls/src/hyperparams.rs	21.05% <0.00%> (-0.38%)	⬇️
...rithms/linfa-trees/src/decision_trees/algorithm.rs	49.65% <0.00%> (-0.18%)	⬇️
algorithms/linfa-nn/tests/nn.rs	78.04% <0.00%> (ø)
algorithms/linfa-linear/src/glm/mod.rs	56.25% <0.00%> (ø)
algorithms/linfa-pls/src/pls_generic.rs	69.64% <0.00%> (ø)
algorithms/linfa-svm/src/classification.rs	60.23% <0.00%> (ø)
...orithms/linfa-clustering/src/dbscan/hyperparams.rs	0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.