Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update criterion settings #276

Merged
merged 31 commits into from
Nov 17, 2022
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e9b5f7c
update criterion settings
oojo12 Nov 11, 2022
9a2156b
update settings
oojo12 Nov 11, 2022
8df41c0
update
oojo12 Nov 11, 2022
ecdfc1e
add benches to all targets
oojo12 Nov 11, 2022
820ce31
Merge branch 'master' into update-benchmarks
oojo12 Nov 11, 2022
90ba3c6
rustfmt
oojo12 Nov 11, 2022
a7f0e03
Remove (1_000, 5)
oojo12 Nov 13, 2022
dfc9781
fix params
oojo12 Nov 14, 2022
255802c
fix params
oojo12 Nov 14, 2022
589a3e1
add benchmarks feature
oojo12 Nov 16, 2022
800837f
add benchmarks feature
oojo12 Nov 16, 2022
676eb52
use benchmarks feature
oojo12 Nov 16, 2022
dee1d1c
add benchmarks feature
oojo12 Nov 16, 2022
61d5d92
fix empty return
oojo12 Nov 16, 2022
30f8d70
use config for profiling
oojo12 Nov 16, 2022
ae51105
upate
oojo12 Nov 16, 2022
7d6e643
Merge branch 'master' into update-benchmarks
oojo12 Nov 16, 2022
54e8d71
properly use profile config
oojo12 Nov 16, 2022
097af70
Merge branch 'update-benchmarks' of https://github.com/oojo12/linfa i…
oojo12 Nov 16, 2022
7e6d9ba
fix failing test
oojo12 Nov 16, 2022
b4a26fb
mention configurable defaults
oojo12 Nov 16, 2022
5302fb7
address review
oojo12 Nov 16, 2022
0ab482d
address review
oojo12 Nov 16, 2022
dd957e1
rustfmt
oojo12 Nov 16, 2022
8b0063e
finalize
oojo12 Nov 16, 2022
21b78b4
update to use cargo criterion
oojo12 Nov 16, 2022
f0b3056
add cargo criterion note
oojo12 Nov 16, 2022
ce93357
fix command
oojo12 Nov 16, 2022
c495998
note about profiling and windows
oojo12 Nov 16, 2022
cc0b235
address review
oojo12 Nov 16, 2022
a4de64e
grammar
oojo12 Nov 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add cargo criterion note
oojo12 committed Nov 16, 2022
commit f0b3056c6e45b86575a20e144bce40c2f72f7d94
1 change: 1 addition & 0 deletions CONTRIBUTE.md
Original file line number Diff line number Diff line change
@@ -174,6 +174,7 @@ It is important to the project that we have benchmarks in place to evaluate the
10. Use the benchmark feature to configure your benchmark groups and profiler. See the bench in linfa-pls as an example of this. In most cases you can just copy and paste portions of the configuration aspects of that code. If other configurations are desired it is still easily customizable and explained in the pprof and Criterion documentation.

### Running Benchmarks
*Note you must first install cargo criterion with `cargo install cargo-criterion`*
When running benchmarks sometimes you will want to profile the code execution. Assuming you have followed step 9 to add a pprof profiling hook for the linfa-ica package you can run the following to get your profiling results as a flamegraph.

`cargo criterion bench -p linfa-ica --bench fast_ica -- --profile-time 30`