Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose references to the PCA components and column means #327

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

hamishs
Copy link
Contributor

@hamishs hamishs commented Jan 2, 2024

Adds methods to Pca that return references to the fitted embedding matrix (named components) and the mean. The components are useful for understanding the relative importance of each feature in the decomposition. The mean is included for completeness as this is in addition to the singular values for which a method already exists.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d495562) 36.71% compared to head (934184c) 36.12%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   36.71%   36.12%   -0.60%     
==========================================
  Files          94       92       -2     
  Lines        6242     6218      -24     
==========================================
- Hits         2292     2246      -46     
- Misses       3950     3972      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@quietlychris quietlychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@quietlychris quietlychris merged commit 0ade794 into rust-ml:master Jan 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants