Skip to content
This repository was archived by the owner on Jul 3, 2020. It is now read-only.

Propagate additional cargo build options #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

staktrace
Copy link

No description provided.

@staktrace
Copy link
Author

Mostly I'm interested in --frozen but I figured I'd do the rest as well.

@staktrace
Copy link
Author

(Note that the circleci failure happens on the master branch too)

@staktrace
Copy link
Author

Updated PR to actually properly propagate the subcommand arguments along to cargo, which it wasn't doing before.

@jrmuizel
Copy link

Review ping?

@goddessfreya
Copy link
Contributor

cc @mb64

@mb64
Copy link
Contributor

mb64 commented Jul 23, 2019

I tried this out with a simple --color never just to make sure it works, and while it no longer complains about Found argument '--color' which wasn't expected, or isn't valid in this context, the Cargo output was as colorful as ever. It seems that while the arguments are parsed correctly, they aren't getting propagated to the cargo process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants