-
Notifications
You must be signed in to change notification settings - Fork 49
Don't activate default features of env_logger #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks like a sane thing to do if it reduces the binary size.
This dependency was probably brought in by fancier log filter. I need to check if it works as expected with this change, add a feature to disable it if it does not work for some reason.
Since this breaks backwards compatibility, would make this crate work differently than default
|
998b842
to
0c404d5
Compare
Sorry, looks like we need to leave |
Oh, true. I should not send PRs before my first coffee in the morning :D |
These are the default features of
So |
This change is good overall, because we certainly don't need other |
This allows to deactivate the feature if wanted. env_logger comes with several optional-but-default-activated features, including a dependency on regex. Not everyone likes to pull in regex. Putting this behind a feature allows users of android_logger to use it with default-features=false and thus removing the regex dependency.
0c404d5
to
1db5caf
Compare
Well, then... |
env_logger comes with several optional-but-default-activated features,
including a dependency on regex.
There's no need for android_logger to require that. Deactivating default
features allows users of android_logger to define the features they
need.