Fix permissions of add_lib, when copying readonly libraries (e.g. of nix/store) to avoid a Permissions Denied Error #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nix/store) to avoid a Permissions Denied Error
MarijnS95
reviewed
Jun 28, 2023
| std::fs::copy(path, out)?; | ||
| fs::copy(path, out.clone())?; | ||
| #[cfg(target_family = "unix")] | ||
| fs::set_permissions(out, fs::Permissions::from_mode(0o644))?; |
There was a problem hiding this comment.
This should at the very least have a comment documenting this workaround for Nix 😉
|
Not sure if it matters but there is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues when using this with NixOS and the android-sdk in the
/nix/storewhich is completely read-only.It copied the file from there and kept the permissions of it, running
cargo apka second time resulted in an Permissions denied error, because the file couldn't be overwritten.This fix just sets the permissions to standard
644permissions, which is AFAIK recommended for files like.so.I think this could also be fixed, by just setting the user write permission bit of the file (a matter of preference I guess).