-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release cargo-apk-0.9.7 #4
Conversation
This provides better workspace detection based on `$PWD` or `--manifest-path`.
Now that we have merged stuff in this repo I think it will be a bit tricky to rebase and change any of the patches on the top of the filtered repo without confusing github (it will change commit hashes) That's ok if we agree to address any issues via new patches on top + PRs from now on. Hopefully all the big stuff is fine. |
@rib If that's re. my comments on your initial porting commits, I think pushing fixes to address those comments on top (via a PR for review) is fine. I wasn't really sure if you were still planning on force-pushing though I was already told to not use the |
Right, esp if spinning a release from here we definitely wont want to force push anything here any more, so we can aim to handle any feedback or issues with the patches I made via PRs. |
Can filter-branch also transplant the tags for |
I'm not sure if that was an option but yeah we'll just have to recreate older release tags manually to bring those across |
I just pushed the few that I needed to create the release, having the rest would be nice for back-reference but might be better to leave those to the original repo, it's a lot of work unless you start comparing patchids (for the subdirectory if possible) or commit titles that have |
It's probably best to just defer to the tags in this repo for older releases, considering that the standalone repo won't build correctly for all those past commits that correspond to releases (unless you would back port the changes I made on top). |
Correct, it'll only generate lots of "failed CI" traffic. |
Fixes rust-mobile/ndk#375
Depends on #3
Initially opened as rust-mobile/ndk#376