error: Include file paths as error context; distinguish toml parsing errors from "manifest not found" #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While implementing #12 an invalid `.cargo/config.toml` turned into an undescriptive and incorrect `ManifestNotFound` here. Forwarding the parsing error gives the user a much more descriptive error message that'll help understand what to fix.
MarijnS95
commented
Mar 3, 2022
| @@ -10,6 +11,7 @@ pub enum Error { | |||
| RustcNotFound, | |||
| Io(IoError), | |||
| GlobPatternError(&'static str), | |||
| Toml(PathBuf, TomlError), | |||
There was a problem hiding this comment.
@dvc94ch Before merging this, shall I do the same for at least IoError? It's a bit annoying to see "No such file or directory" without knowing what the path was.
There was a problem hiding this comment.
Sounds good. Wish io errors were more descriptive by default.
MarijnS95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #12 an invalid
.cargo/config.tomlturned into an undescriptive and incorrectManifestNotFoundhere. Forwarding the parsing error gives the user a much more descriptive error message that'll help understand what to fix.