subcommand: Parse and propagate [env] vars at the earliest possible moment
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… moment Strangely enough I added this call at a random place in `Subcommand::new()`, instead of considering that it was both: 1. Breaking the logic for deducing `target_dir` in two separated blocks; 2. Preventing the first block - which reads environment variables! - from seeing what was configured in `.cargo/config.toml` through `[env]`. Fix this by moving the call straight after identifying the root directory for the selected package.
|
@dvc94ch This reminds me, I have no idea how |
dvc94ch
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strangely enough I added this call at a random place in
Subcommand::new(), instead of considering that it was both:target_dirin two separated blocks;.cargo/config.tomlthrough[env].Fix this by moving the call straight after identifying the root directory for the selected package.